Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin UI: Closing settings dialog closes page below #826

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Admin UI: Closing settings dialog closes page below #826

merged 1 commit into from
Sep 2, 2024

Conversation

jkoenig134
Copy link
Member

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@jkoenig134 jkoenig134 added the bug Something isn't working label Sep 2, 2024
@jkoenig134 jkoenig134 requested a review from tnotheis September 2, 2024 06:45
@jkoenig134 jkoenig134 enabled auto-merge (squash) September 2, 2024 06:59
@jkoenig134 jkoenig134 merged commit be84239 into main Sep 2, 2024
25 checks passed
@jkoenig134 jkoenig134 deleted the closing-settings-dialog-closes-page-below branch September 2, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnotheis tnotheis tnotheis approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkoenig134 @tnotheis